Skip to content

Fix for --embind-emit-tsd + -sMODULARIZE #20051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix for --embind-emit-tsd + -sMODULARIZE #20051

merged 1 commit into from
Aug 24, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 16, 2023

Fixes: #20012

@sbc100 sbc100 requested a review from brendandahl August 16, 2023 17:43
brendandahl
brendandahl approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. r+ w/ comment addressed

@sbc100 sbc100 merged commit 7b3d638 into main Aug 24, 2023
@sbc100 sbc100 deleted the emit_tsd branch August 24, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandahl brendandahl brendandahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Typescript Binding generation
2 participants
@sbc100 @brendandahl