Mark test_pthread_print_override_modularize as flaky. NFC #20143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was already being disabled on mac due to flakiness, but I've also seen the flake on linux now. See #19683
|
Should we wait a little on this, to see just how flaky the test is? |
I don't think its a super important test, and it exhibits the symptoms of a known flake on pthread shutdown. Within reason, I'm pretty keen the get the flakiness of the waterfall down to zero. If we start marking large numbers of tests as flaky we can revisit but for now I think this is good addition. |
dschuff
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was already being disabled on mac due to flakiness, but I've also seen the flake on linux now.
See #19683