FIX Turn off settings.LTO if -fno-lto is passed
#20309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I checked that the test fails without the patch. |
sbc100
reviewed
Sep 21, 2023
test/test_other.py
Outdated
| @@ -11148,6 +11148,23 @@ def test_setjmp_emulated_casts(self): | |||
| ''') | |||
| self.do_runf('src.c', 'ok\ndone\n', emcc_args=['-sEMULATE_FUNCTION_POINTER_CASTS']) | |||
|
|
|||
| def test_setjmp_no_lto(self): | |||
There was a problem hiding this comment.
Perhaps just call this test_no_lto.. and add a comment with a link to the bug, since this seems like a very specific regression test.
sbc100
approved these changes
Sep 21, 2023
|
Thanks for looking into this and fixed it! |
|
test-browser-chrome seems to have some flakes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20308.