Always assert on calling proxied function from wasm worker. NFC #20343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
approved these changes
Sep 27, 2023
juj
reviewed
Sep 27, 2023
| @@ -3769,7 +3769,7 @@ function wrapSyscallFunction(x, library, isWasi) { | |||
| if (!WASMFS) { | |||
| library[x + '__deps'].push('$SYSCALLS'); | |||
| } | |||
| #if PTHREADS | |||
| #if SHARED_MEMORY | |||
There was a problem hiding this comment.
I think this #if could be dropped altogether? The proxying directives can exist independent of the build configuration one is running with, and don't need to be gated to only be specified in multithreaded builds?
sbc100
force-pushed
the
wasm_worker_proxy_asserts
branch
from
aaae986 to
cd8d638
Compare
sbc100
force-pushed
the
wasm_worker_proxy_asserts
branch
from
cd8d638 to
3dbef5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20135.
See #20135 (comment)