[NFC] Add more comments to pthread mailbox infrastructure #20511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
sbc100
reviewed
Oct 24, 2023
src/library_pthread.js
Outdated
| // If we are using Atomics.waitAsync as our notification mechanism, wait | ||
| // for a notification before processing the mailbox to avoid missing any | ||
| // work that could otherwise arrive after we've finished processing the | ||
| // mailbox and before we're ready for the next notification. | ||
| __emscripten_thread_mailbox_await(pthread_ptr); | ||
| callUserCallback(() => __emscripten_check_mailbox()); |
There was a problem hiding this comment.
I just noticed that this can be callUserCallback(__emscripten_check_mailbox)
RReverser
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
I think my questions were more about ordering of wait.value.then(...) callback vs setting flags, which this doesn't quite cover, but from recent conversation it sounds like it should be possible to change those implementation details anyway, so maybe it's not really worth documenting them for now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.