Skip to content

Fix benchmark profiling logic #20647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix benchmark profiling logic #20647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/test_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def build(self, parent, filename, args, shared_args, emcc_args, native_args, nat
] + LLVM_FEATURE_FLAGS
if shared_args:
cmd += shared_args
if common.EMTEST_FORCE64:
if PROFILING:
cmd += ['--profiling']
else:
cmd += ['--closure=1', '-sMINIMAL_RUNTIME']
Expand All @@ -220,8 +220,6 @@ def build(self, parent, filename, args, shared_args, emcc_args, native_args, nat
cmd += emcc_args + self.extra_args
if '-sFILESYSTEM' not in cmd and '-sFORCE_FILESYSTEM' not in cmd:
cmd += ['-sFILESYSTEM=0']
if PROFILING:
cmd += ['--profiling-funcs']
self.cmd = cmd
run_process(cmd, env=self.env)
if self.binaryen_opts:
Expand Down