Fix malloc_bench calloc logic #20648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Nov 7, 2023
test/malloc_bench.c
Outdated
| @@ -85,7 +85,7 @@ void randoms() { | |||
| total_allocated += size; | |||
| } | |||
| } else { | |||
| if (calloc_ && USE_CALLOC) { | |||
| if (!calloc_ || !USE_CALLOC) { | |||
There was a problem hiding this comment.
Keep the condition expressed in positives and flip the bodies instead?
What is calloc_ (with the trailing underscore)? When would USE_CALLOC befined but not calloc_
There was a problem hiding this comment.
The benchmark has a global setting USE_CALLOC, and a random decision in each iteration as well. So it is checking if we allow calloc both globally and locally.
I'll reverse the condition.
sbc100
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition was flipped, that is, if calloc mode was disabled we actually ran
calloc.