Skip to content

[test] Remove duplicate no_wasm64 decorator. NFC #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,9 @@ class RunnerCore(unittest.TestCase, metaclass=RunnerMeta):
def is_wasm(self):
return self.get_setting('WASM') != 0

def is_wasm2js(self):
return not self.is_wasm()

def is_browser_test(self):
return False

Expand Down
16 changes: 1 addition & 15 deletions test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from common import skip_if, needs_dylink, no_windows, no_mac, is_slow_test, parameterized
from common import env_modify, with_env_modify, disabled, flaky, node_pthreads, also_with_wasm_bigint
from common import read_file, read_binary, requires_v8, requires_node, requires_node_canary, compiler_for, crossplatform
from common import with_both_sjlj, also_with_standalone_wasm, can_do_standalone
from common import with_both_sjlj, also_with_standalone_wasm, can_do_standalone, no_wasm64
from common import NON_ZERO, WEBIDL_BINDER, EMBUILDER, PYTHON
import clang_native

Expand Down Expand Up @@ -134,14 +134,6 @@ def decorated(f):
return decorated


def no_wasm64(note=''):
assert not callable(note)

def decorated(f):
return skip_if(f, 'is_wasm64', note)
return decorated


def also_with_noderawfs(func):
assert callable(func)

Expand Down Expand Up @@ -356,12 +348,6 @@ def is_sanitizing(args):


class TestCoreBase(RunnerCore):
def is_wasm2js(self):
return self.get_setting('WASM') == 0

def is_wasm64(self):
return self.get_setting('MEMORY64')

# A simple check whether the compiler arguments cause optimization.
def is_optimizing(self):
return '-O' in str(self.emcc_args) and '-O0' not in self.emcc_args
Expand Down