Cleanup strftime tests. NFC #20657
Merged
Cleanup strftime tests. NFC #20657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core test now reports errors using `assert` which links directly the line number of the failure. The other test is now written in pure C (which I think makes it a lot easier to read).
|
In #20470 I see that it caused breakage - should we avoid landing this for now to see if we need to revert it? Landing this would prevent a clean revert I think? |
|
This cleanup is of strftime tests. Only strptime tests were modified by #20470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core test now reports errors using
assertwhich links directly the line number of the failure.The other test is now written in pure C (which I think makes it a lot easier to read).