Skip to content

Re-enable wasmfs metadce tests after roll #20855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Re-enable wasmfs metadce tests after roll #20855

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76c586c
Re-enable wasmfs metadce tests after roll [ci skip]
kripken Dec 5, 2023
f69847b
Merge remote-tracking branch 'origin/main' into roll
kripken Dec 6, 2023
6578772
silly
kripken Dec 6, 2023
775ce12
Revert "silly"
kripken Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8296,8 +8296,7 @@ def test_metadce_minimal_pthreads(self):
# code. mode 2 ignores those and fully optimizes out the ctors
'ctors1': (['-O2', '-sEVAL_CTORS'], [], ['waka']), # noqa
'ctors2': (['-O2', '-sEVAL_CTORS=2'], [], ['waka']), # noqa
# disable for roll
# 'wasmfs': (['-O2', '-sWASMFS'], [], ['waka']), # noqa
'wasmfs': (['-O2', '-sWASMFS'], [], ['waka']), # noqa
})
def test_metadce_cxx(self, *args):
# do not check functions in this test as there are a lot of libc++ functions
Expand All @@ -8320,8 +8319,7 @@ def test_metadce_cxx(self, *args):
# larger for wasm backend.
'dylink': (['-O3', '-sMAIN_MODULE=2'], [], []), # noqa
# WasmFS should not be fully linked into a hello world program.
# disable for roll
# 'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
})
def test_metadce_hello(self, *args):
self.run_metadce_test('hello_world.cpp', *args)
Expand Down Expand Up @@ -8362,8 +8360,7 @@ def test_metadce_libcxxabi_message(self, *args):

@parameterized({
'js_fs': (['-O3', '-sNO_WASMFS'], [], []), # noqa
# disable for roll
# 'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
})
def test_metadce_files(self, *args):
self.run_metadce_test('files.cpp', *args)
Expand Down