Skip to content

Add depthSlice to WGPURenderPassColorAttachment #21057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

beaufortfrancois
Copy link
Contributor

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, but this needs a JS change too, here:

(EDIT: wrong code)

@kainino0x
Copy link
Collaborator

kainino0x commented Jan 10, 2024

sorry, that code was wrong.

var depthSlice = {{{ gpu.makeGetU32('caPtr', C_STRUCTS.WGPURenderPassColorAttachment.depthSlice) }}};
{{{ gpu.convertSentinelToUndefined('depthSlice') }}}
        "depthSlice": depthSlice,

@beaufortfrancois
Copy link
Contributor Author

Thank you @kainino0x. I've updated the PR with your suggestions.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kainino0x kainino0x merged commit 90ccf08 into emscripten-core:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants