Use musl implementation of gethostbyname/gethostbyaddr functions. NFC #21067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
gethostbyname
branch
2 times, most recently
from
036f25f to
c5bc62c
Compare
kripken
reviewed
Jan 11, 2024
|
|
||
| *canon = 0; | ||
| if (name) { | ||
| /* reject empty name and check len so it fits into temp bufs */ |
There was a problem hiding this comment.
I see a check for an empty name, but where is it rejected? (It looks like we continue down and send null to UTF8ToString in JS, which is fine.)
There was a problem hiding this comment.
I don't think we handle that case.. but also the old code didn't handle it either, so I'm temped to leave it as is. I think passing NULL to gethostbyname is most likely undefined behaviour and I suppose we don't have a test for it.
sbc100
force-pushed
the
gethostbyname
branch
2 times, most recently
from
576fe15 to
f655248
Compare
kripken
approved these changes
Jan 11, 2024
Instead of implementing these directly in JS, we now implement a much lower level lookup function and rely on musl for all the higher level stuff. `gethostbyname` bottoms out in `_emscripten_lookup_name` and `gethostbyaddr` bottomrs out in `getnameinfo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of implementing these directly in JS, we now implement a much lower level lookup function and rely on musl for all the higher level stuff.
gethostbynamebottoms out in_emscripten_lookup_nameandgethostbyaddrbottomrs out ingetnameinfo