Re-enable running of closure compiler under java #21093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
closure_compiler_test
branch
2 times, most recently
from
bb4f850 to
9ce8b35
Compare
sbc100
changed the title
This is a partial revert of emscripten-core#20919. It turns out that we were still depending on falling back to the java version of closure compiler in some cases. Specifically, on macOS arm64 when Rosetta is not installed, we were falling back to the Java version since google-closure-compiler doesn't ship arm64 binaries. I imagine the same will be true of linux-arm64.
sbc100
force-pushed
the
closure_compiler_test
branch
from
9ce8b35 to
13003db
Compare
kripken
approved these changes
Jan 17, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 17, 2024
This change also reverts the changes made to test_other.py in emscripten-core#20919.
sbc100
added a commit
that referenced
this pull request
Jan 17, 2024
|
This is breaking on chromium CI: https://chromium-review.googlesource.com/c/emscripten-releases/+/5207485 |
|
Sorry, there was a followup because I landed this change without waiting for all tests to pass: #21097. Shame on me :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #20919.
It turns out that we were still depending on falling back to the java
version of closure compiler in some cases. Specifically, on macOS arm64
when Rosetta is not installed, we were falling back to the Java version
since google-closure-compiler doesn't ship arm64 binaries. I imagine
the same will be true of linux-arm64.