Skip to content

[NFC] Add assert to emmalloc test #21831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 25, 2024

The test checked alignment of the output of aligned_alloc, but that method
returns 0 on errors and 0 is fully aligned, so in theory the test could have
missed a problem.

@kripken kripken requested a review from sbc100 April 25, 2024 18:54
@kripken kripken merged commit 9fdf8af into emscripten-core:main Apr 25, 2024
@kripken kripken deleted the emmalloc.test branch April 25, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants