Add openal alext.h header #21857
Add openal alext.h header #21857
Conversation
| /** | ||
| * OpenAL cross platform audio library | ||
| * Copyright (C) 2008 by authors. | ||
| * This library is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Library General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 2 of the License, or (at your option) any later version. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Library General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Library General Public | ||
| * License along with this library; if not, write to the | ||
| * Free Software Foundation, Inc., | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * Or go to http://www.gnu.org/copyleft/lgpl.html | ||
| */ |
There was a problem hiding this comment.
not sure if I should leave this here, especially since I modified the file
There was a problem hiding this comment.
Yes, you should leave this here.
What modifications did you make exactly?
There was a problem hiding this comment.
I removed a bunch of typedefs that were causing errors, as well as removed the import of efx.h
| @@ -0,0 +1,71 @@ | |||
| // So far just does some sanity checks for the available extensions. | |||
There was a problem hiding this comment.
Do I need to add some license info at the top here
There was a problem hiding this comment.
Yup, you can copy the one from any of the other test files.
| /** | ||
| * OpenAL cross platform audio library | ||
| * Copyright (C) 2008 by authors. | ||
| * This library is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Library General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 2 of the License, or (at your option) any later version. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Library General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Library General Public | ||
| * License along with this library; if not, write to the | ||
| * Free Software Foundation, Inc., | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * Or go to http://www.gnu.org/copyleft/lgpl.html | ||
| */ |
There was a problem hiding this comment.
Yes, you should leave this here.
What modifications did you make exactly?
| @@ -0,0 +1,71 @@ | |||
| // So far just does some sanity checks for the available extensions. | |||
There was a problem hiding this comment.
Yup, you can copy the one from any of the other test files.
|
@sbc100 it looks like I'm failing some tests. I'm not exactly sure how to parse the output, but it seems it might have something to do with size? Is the alext.h perhaps too large? |
|
It looks like maybe your branch is not up-to-date with the current main branch? Can you try rebasing or merging? |
gabeklavans
force-pushed
the
openal-alext-support
branch
from
809a594 to
19827be
Compare
|
The test failure you are seeing here is unrelated and should be fixed in #21885 |
all the error-generating lines seem to be either typedefs that aren't needed here or related to efx.h, which can be omitted for now
gabeklavans
force-pushed
the
openal-alext-support
branch
from
6a1c290 to
49644a6
Compare
|
It was pointed out that this header is licences under the BSD licence and so far all our runtime code is MIT licenced. So I think we will have to revert this and create our own version of this header outselves. @gabeklavans would you be up for doing this? If you can do it in the next few days we can maybe avoid reverting this PR |
How's this sound: if I don't get it done by Friday (Aug 9th) 11:00 PM EST you can go ahead and revert. I'm not sure if I'll be able to finish it up but I can give it a shot. Additionally, what would constitute our own version? I'd want to keep all the API-side defines the same as what is documented for OpenAL soft. So I suppose if I just start the header from scratch and only define what we need, would that suffice? |
|
Yes, something like this: 38a151b |
I couldn't find mention of the version of openal-soft that al.h and alc.h were pulled from, so I somewhat arbitrarily pulled alext.h from openal-soft v1.19.1. Let me know if those versions are recorded somewhere.
resolves #21723