Cleanup symlink tests #21890
Merged
Cleanup symlink tests #21890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
symlink_tests
branch
5 times, most recently
from
5de9dc4 to
d8fb93e
Compare
- Add some more tests to `links.c` and make sure it runs on native linux. - Simplify symlink_on_nodefs.c by using assert. Also, fix `utils.delete_content` so that it also removes dangling symlinks. Without this the dangling symlinks in the test output directory are not removed.
dschuff
reviewed
May 6, 2024
| fs.mkdirSync('./new-directory', '0777'); | ||
| fs.writeFileSync('./new-directory/test', 'Link it'); | ||
| fs.symlinkSync(fs.realpathSync('./new-directory'), './symlink'); | ||
| fs.mkdirSync('new-directory', '0777'); |
There was a problem hiding this comment.
what's the difference between fs and FS?
There was a problem hiding this comment.
fs is working directly with the real (node) filesystem. (e.g. import * as fs from "fs" in node)
FS is the emscripten VFS.
kripken
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more tests to
links.cand make sure it runs on native linux.Simplify symlink_on_nodefs.c by using assert.