-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Avoid calling addEventListener
in audio worklet
#21897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sbc100
merged 4 commits into
emscripten-core:main
from
WavTool:fix-audio-worklet-workers-mix
May 7, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#include <emscripten/webaudio.h> | ||
#include <emscripten/wasm_worker.h> | ||
#include <emscripten/threading.h> | ||
#include <stdio.h> | ||
#include <stdlib.h> | ||
#include <assert.h> | ||
|
||
// Tests that | ||
// - audioworklets and workers can be used at the same time. | ||
// - an audioworklet can emscripten_futex_wake() a waiting worker. | ||
// - global values can be shared between audioworklets and workers. | ||
|
||
int workletToWorkerFutexLocation = 0; | ||
int workletToWorkerFlag = 0; | ||
|
||
void run_in_worker() { | ||
while (0 == emscripten_futex_wait(&workletToWorkerFutexLocation, 0, 30000)) { | ||
if (workletToWorkerFlag == 1) { | ||
printf("Test success\n"); | ||
break; | ||
} | ||
} | ||
|
||
#ifdef REPORT_RESULT | ||
REPORT_RESULT(workletToWorkerFlag == 1); | ||
#endif | ||
} | ||
|
||
// This event will fire on the audio worklet thread. | ||
void MessageReceivedInAudioWorkletThread() { | ||
assert(emscripten_current_thread_is_audio_worklet()); | ||
workletToWorkerFlag = 1; | ||
emscripten_futex_wake(&workletToWorkerFutexLocation, 1); | ||
} | ||
|
||
void WebAudioWorkletThreadInitialized(EMSCRIPTEN_WEBAUDIO_T audioContext, EM_BOOL success, void *userData) { | ||
emscripten_audio_worklet_post_function_v(audioContext, MessageReceivedInAudioWorkletThread); | ||
} | ||
|
||
uint8_t wasmAudioWorkletStack[4096]; | ||
|
||
int main() { | ||
emscripten_wasm_worker_t worker = emscripten_malloc_wasm_worker(/*stackSize: */1024); | ||
emscripten_wasm_worker_post_function_v(worker, run_in_worker); | ||
|
||
EMSCRIPTEN_WEBAUDIO_T context = emscripten_create_audio_context(0); | ||
emscripten_start_wasm_audio_worklet_thread_async(context, wasmAudioWorkletStack, sizeof(wasmAudioWorkletStack), WebAudioWorkletThreadInitialized, 0); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.