Skip to content

Fix findMatchingCatch iterating over argument array prototype chain #21986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix findMatchingCatch iterating over argument array prototype chain #21986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1be82
Fix findMatchingCatch iterating over argument array prototype chain
luxaritas May 23, 2024
fc4e362
Include the actual fix I missed due to a bad copy-paste
luxaritas May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/library_exceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,7 @@ var LibraryExceptions = {
// Due to inheritance, those types may not precisely match the
// type of the thrown object. Find one which matches, and
// return the type of the catch block which should be called.
for (var arg in args) {
var caughtType = args[arg];

for (var caughtType of args) {
if (caughtType === 0 || caughtType === thrownType) {
// Catch all clause matched or exactly the same type is caught
break;
Expand Down
Loading