Skip to content

Update libunwind to LLVM 19.1.4 #22934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Nov 15, 2024

Other than these two PRs I submitted to upstream LLVM, all other changes are unrelated upstream changes.
llvm/llvm-project#92192
llvm/llvm-project#92840

This PR was created by running https://github.com/emscripten-core/emscripten/blob/main/system/lib/update_libunwind.py script.

@aheejin aheejin marked this pull request as ready for review November 16, 2024 05:28
@aheejin aheejin requested a review from sbc100 November 16, 2024 05:28
@sbc100
Copy link
Collaborator

sbc100 commented Nov 18, 2024

Are all these change from upstream or are there some new downstream patches too?

Did you already update the emscripten llvm-project fork?

Was this change created solely by system/lib/update_compiler_rt.py? If so can you mention that in the PR descirption?

Can you update system/lib/compiler-rt/readme.txt?

@aheejin
Copy link
Member Author

aheejin commented Nov 19, 2024

Are all these change from upstream or are there some new downstream patches too?

Other than these two PRs I submitted to upstream LLVM, all other changes are unrelated upstream changes.
llvm/llvm-project#92192
llvm/llvm-project#92840

I updated the PR description too.

Did you already update the emscripten llvm-project fork?

I have created emscripten-libs-19 branch based on llvmorg-19.1.3 tag:
https://github.com/emscripten-core/llvm-project/tree/emscripten-libs-19
But I haven't uploaded the cherry-picking of our downstream patches onto that branch yet. I resolved conflicts, but given that that does not work here in Emscripten CI yet, I think that would need more fixes, so I thought I would upload them after fixing all CI failures here. Do you prefer to upload the apparent conflict-fixes first and then other fixes later to that branch?

Was this change created solely by system/lib/update_compiler_rt.py? If so can you mention that in the PR descirption?

Done.

Can you update system/lib/compiler-rt/readme.txt?

Done. I also updated ChangeLog.

@aheejin
Copy link
Member Author

aheejin commented Nov 19, 2024

Given that 19.1.4 was released 10 hours ago(!), I'll probably update the version to that in this PR soon.

@sbc100
Copy link
Collaborator

sbc100 commented Nov 19, 2024

lgtm once the tests pass!

@aheejin aheejin changed the title Update libunwind to LLVM 19.1.3 Update libunwind to LLVM 19.1.4 Nov 20, 2024
@aheejin aheejin merged commit 119a427 into emscripten-core:main Nov 20, 2024
28 checks passed
@aheejin aheejin deleted the update_libunwind_19 branch November 20, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants