Skip to content

Implement support for WebGPU viewFormats in surface configuration #22961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

jankrassnigg
Copy link
Contributor

Fixes #22939.

Tested with a custom application on my machine.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@kainino0x kainino0x enabled auto-merge (squash) November 19, 2024 23:26
@kainino0x kainino0x disabled auto-merge November 19, 2024 23:31
@kainino0x kainino0x enabled auto-merge (squash) November 19, 2024 23:32
@kainino0x
Copy link
Collaborator

Ported forward to emdawnwebgpu here: https://dawn-review.googlesource.com/c/dawn/+/215834

@kainino0x kainino0x merged commit f03605d into emscripten-core:main Nov 20, 2024
28 checks passed
copybara-service bot pushed a commit to google/dawn that referenced this pull request Nov 20, 2024
From emscripten-core/emscripten#22961

Co-authored-by: Jan Krassnigg <[email protected]>
No-Try: true
Change-Id: I292829616a7dac543a9500847a7112af4487afcb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215834
Reviewed-by: Loko Kung <[email protected]>
Commit-Queue: Kai Ninomiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPU doesn't implement surface viewFormats
3 participants