Fix import.meta.dirname in node 18

[kripken]

Likely I am doing something wrong, but I need this change, or else this happens for me locally with node v18.20.1:

$ ./emcc test/hello_world.c
node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:405:5)
    at validateString (node:internal/validators:162:11)
    at Module.join (node:path:1171:7)
    at find (file:///emscripten/src/utility.mjs:235:27)
    at read (file:///emscripten/src/utility.mjs:229:20)
    at file:///emscripten/src/compiler.mjs:30:34
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:106:12) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v18.20.1
emcc: error: 'nodejs emscripten/src/compiler.mjs /tmp/tmp9wv0eyav.json' failed (returned 1)

Clearing the cache, running bootstrap, npm ci etc., nothing works except for this patch.

[sbc100]

No, you are not doing anything wrong. This was an unfortunate side effect of #23349. I accidentally caused the compiler to start requiring node v19.

See #23396

emsdk was updated to v20 a while back now so it went unnoticed.

How did you end up with v18 on your system? Is it an old emsdk version maybe? Maybe you also forgot to do emsdk activate latest?

[kripken]

This is just the system node. I have it set to be used in my .emscripten file I guess, from a long time ago.

This does seem to fix things for me. Can we land it, or does it have downsides?

[sbc100]

The right way to revert this would be to restore this part of the code to how it was before #23349.

[kripken]

Ok, I'll switch to 20 locally then.

[sbc100]

No, we should still support v18 if its the one in debian/stable. Working on anther change now..