Skip to content

Commit 599e2b1

Browse files
authored
urlpatterns: Remove unnecessary branching (#7405)
Functions path and register_converter are constants.
1 parent 1e164c5 commit 599e2b1

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

rest_framework/urlpatterns.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,9 @@ def format_suffix_patterns(urlpatterns, suffix_required=False, allowed=None):
105105
else:
106106
suffix_pattern = r'\.(?P<%s>[a-z0-9]+)/?$' % suffix_kwarg
107107

108-
if path and register_converter:
109-
converter_name, suffix_converter = _get_format_path_converter(suffix_kwarg, allowed)
110-
register_converter(suffix_converter, converter_name)
108+
converter_name, suffix_converter = _get_format_path_converter(suffix_kwarg, allowed)
109+
register_converter(suffix_converter, converter_name)
111110

112-
suffix_route = '<%s:%s>' % (converter_name, suffix_kwarg)
113-
else:
114-
suffix_route = None
111+
suffix_route = '<%s:%s>' % (converter_name, suffix_kwarg)
115112

116113
return apply_suffix_patterns(urlpatterns, suffix_pattern, suffix_required, suffix_route)

0 commit comments

Comments
 (0)