Skip to content

urlpatterns: Remove unnecessary branching #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

urlpatterns: Remove unnecessary branching #7405

merged 1 commit into from
Jul 23, 2020

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 11, 2020

Functions path and register_converter are constants.

@jayvdb
urlpatterns: Remove unnecessary branching
722ef93 
Functions path and register_converter are constants.
@jayvdb jayvdb mentioned this pull request Jul 12, 2020
Closed
kevin-brown
kevin-brown approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@kevin-brown kevin-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this was leftover from some compat work in the past.

@carltongibson carltongibson merged commit 599e2b1 into encode:master Jul 23, 2020
@carltongibson
Copy link
Collaborator

Great. Thanks.

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@jayvdb @sigvef
urlpatterns: Remove unnecessary branching (encode#7405)
31e341a 
Functions path and register_converter are constants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-brown kevin-brown kevin-brown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayvdb @carltongibson @kevin-brown