Merge pull request #3198 from jpadilla/search

Fix weird search behavior

Author: tomchristie

docs_theme/base.html

@@ -69,7 +69,7 @@ <h3 id="myModalLabel">Documentation search</h3>
           </div>
 
           <div class="modal-body">
-            <form role="form">
+            <form role="form" autocomplete="off">
               <div class="form-group">
                 <input type="text" name="q" class="form-control" placeholder="Search..." id="mkdocs-search-query">
               </div>

docs_theme/js/theme.js

@@ -1,35 +1,35 @@
-function getSearchTerm()
-{
-    var sPageURL = window.location.search.substring(1);
-    var sURLVariables = sPageURL.split('&');
-    for (var i = 0; i < sURLVariables.length; i++)
-    {
-        var sParameterName = sURLVariables[i].split('=');
-        if (sParameterName[0] == 'q')
-        {
-            return sParameterName[1];
-        }
+var getSearchTerm = function() {
+  var sPageURL = window.location.search.substring(1);
+  var sURLVariables = sPageURL.split('&');
+  for (var i = 0; i < sURLVariables.length; i++) {
+    var sParameterName = sURLVariables[i].split('=');
+    if (sParameterName[0] === 'q') {
+      return sParameterName[1];
     }
-}
+  }
+};
 
-$(function() {
-
-    var initialise_search = function(){
-        require.config({"baseUrl":"/mkdocs/js"});
-        require(["search",]);
-    }
+var initilizeSearch = function() {
+  require.config({ baseUrl: '/mkdocs/js' });
+  require(['search']);
+};
 
-    var search_term = getSearchTerm();
-    if(search_term){
-        $('#mkdocs_search_modal').modal();
-    }
+$(function() {
+  var searchTerm = getSearchTerm(),
+    $searchModal = $('#mkdocs_search_modal'),
+    $searchQuery = $searchModal.find('#mkdocs-search-query'),
+    $searchResults = $searchModal.find('#mkdocs-search-results');
 
-    $('pre code').parent().addClass('prettyprint well');
+  $('pre code').parent().addClass('prettyprint well');
 
-    $(document).on("submit", "#mkdocs_search_modal form", function (e) {
-        $("#mkdocs-search-results").html("Searching...");
-        initialise_search();
-        return false;
-    });
+  if (searchTerm) {
+    $searchQuery.val(searchTerm);
+    $searchResults.text('Searching...');
+    $searchModal.modal();
+  }
 
+  $searchModal.on('shown', function() {
+    $searchQuery.focus();
+    initilizeSearch();
+  });
 });