Skip to content

Fix broken docs search #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Fix broken docs search #3198

merged 2 commits into from
Jul 30, 2015

Conversation

jpadilla
Copy link
Member

Steps:

  1. Click on search button at the top
  2. Type search term
  3. Hit return. "Searching..." text shows. No results show.
  4. Hit return again. Results show up.

Problem seemed to be with how we were deferring requiring mkdocs search index after hitting return. I changed it to initialize after the modal's shown event has triggered.

untitled

@tomchristie
Copy link
Member

Superstar! Thank you!

tomchristie added a commit that referenced this pull request Jul 30, 2015
Fix weird search behavior
@tomchristie tomchristie merged commit accd8fe into encode:master Jul 30, 2015
@tomchristie tomchristie changed the title Fix weird search behavior Fix broken docs search Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants