Duplicate operationId in OpenAPI schema

[MarkusH]

After upgrading from 3.12.4 to 3.13.0 I noticed that some operationIds in the OpenAPI schema are duplicated. Using the generateschema command I also get warnings:

 django-admin generateschema --file openapi.json --format openapi-json
/tmp/django-rest-framework/rest_framework/schemas/openapi.py:49: UserWarning: You have a duplicated operationId in your OpenAPI schema: listWrappeds
        Route: /api/v1/a/, Method: get
        Route: /api/v1/b/, Method: get
        An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/tmp/django-rest-framework/rest_framework/schemas/openapi.py:49: UserWarning: You have a duplicated operationId in your OpenAPI schema: listWrappeds
        Route: /api/v1/b/, Method: get
        Route: /api/v1/c/, Method: get
        An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/tmp/django-rest-framework/rest_framework/schemas/openapi.py:49: UserWarning: You have a duplicated operationId in your OpenAPI schema: listWrappeds
        Route: /api/v1/c/, Method: get
        Route: /api/v1/d/, Method: get
        An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(

Digging deeper, this is cause by this change: 9c97946

Looking at the implementation of rest_framework.schema.openapi.AutoSchema.get_operation_id_base(), this is somehow related to the else: branch where a trailing APIView string is stripped.

However, looking at the repr of the same view on 3.12.4 and 3.13.0, they look differently:

# 3.12.4
In [1]: from myapp.views import my_view

In [2]: my_view.view_class
Out[2]: myapp.views.WrappedAPIView

In [3]: my_view.view_class.__name__
Out[3]: 'my_view'

# 3.13.0
In [1]: from myapp.views import my_view

In [2]: my_view.view_class
Out[2]: rest_framework.decorators.api_view.<locals>.decorator.<locals>.WrappedAPIView

In [3]: my_view.view_class.__name__
Out[3]: 'WrappedAPIView'

[tomchristie]

Okay - I think a possibly sensible path here is:

• Revert Fix api_view decorator with Django 4 #8291 (Which I assume is what's caused the behaviour change here.)
• Investigate in more detail exactly what issues we have with Django 4.0 that prompted Fix api_view decorator with Django 4 #8291, and address those in a way that doesn't cause this breakage.

[MarkusH]

Thanks @tomchristie. Do you want me to open a MR to revert the commit? Should I turn the topic into a ticket?

[tomchristie]

Not sure - having a look into it now

[tomchristie]

Okay, just straight reverted it for now - 3.13.1.
That's got to be the best course of action to start with.

[MarkusH]

❤️ Thank you @tomchristie . I'll take a shot at the new version.

[MarkusH]

Confirm, 3.13.1 fixes the problem described above. Thanks!