Remove boilerplate code from tox config #2123
Conversation
| - TOX_ENV=py34-djangomaster | ||
| - TOX_ENV=py33-djangomaster | ||
| - TOX_ENV=py32-djangomaster | ||
| - TOX_ENV=py27-djangomaster |
There was a problem hiding this comment.
Is the '.' removal intentional?
I don't particularly mind either ways, but we're using eg django1.7, so seems we may as well stick with the same python style (also it'd keep the changeset minimal, which'd be good for reviewing this)
There was a problem hiding this comment.
Oh sorry, I see your comment above now.
There was a problem hiding this comment.
Yes, it's intentional. I think the dot syntax looks much better, but because tox provides (see the note) the environments, it also knows how to work with basepython by looking at the prefix. With a custom prefix we would either have to redefine all the default envs (which doesn't make that much sense just for prettying stuff up) or override all the env created from the multi-dimensional matrix, which would make the whole refactoring pretty much useless. This is an example of how Tornado redefined theirs https://github.com/tornadoweb/tornado/blob/master/tox.ini#L52.
|
Looks great after the change! The test failures were my fault (template change that I pushed directly to master, didn't expect it to cause failing tests) |
Remove boilerplate code from tox config
|
Noting for other's reference that I needed to do
Not a problem but figured I'd post that somewhere visible so easier to dig out again if anyone is searching with same problem. |
|
This is awesome, updating the cookiecutter to include these changes. |
👍 |
No description provided.