Tweaked a few issues in the tutorial documentation. #2397
Conversation
travelton
commented
Jan 9, 2015
travelton
commented
- Adjusted the verbiage in part 1, to replace the class with the code snippet.
- Removed an unused import in code sample of urls.py in part 3.
- Clarified SnippetDetail view class in part 4.
- Added a missing import in part 5.
|
All seems reasonable to me. Anyone else want to review too and commit if you're happy? |
| @@ -106,6 +106,8 @@ If we're going to have a hyperlinked API, we need to make sure we name our URL p | |||
|
|
|||
| After adding all those names into our URLconf, our final `snippets/urls.py` file should look something like this: | |||
|
|
|||
| from django.conf.urls import url, include | |||
There was a problem hiding this comment.
I think here we should be adding all imports since we are saying "this is how it should be looking"
There was a problem hiding this comment.
I tend to agree... If that's the case, a few other samples show a diff, versus all imports. While I was going through the samples, I would copy/paste and review in my text editor. So it was difficult when diffs were provided. Anyone else have opinions?
|
I'm not totally convinced one way or the other. It does add noise, but get your point. Not fussed about this one, but not sure I'd want to see it repeated everywhere. |
|
@tomchristie yeah I get it. Tutorial isn't meant to be taken out of context I guess, It has continuity from the first one till the last one. I'm ok merging this as is. |
Tweaked a few issues in the tutorial documentation.
|
Thanks @travelton! |
