Skip to content

Add import example for force_authenticate in testing #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Add import example for force_authenticate in testing #2562

merged 1 commit into from
Feb 18, 2015

Conversation

phalt
Copy link
Contributor

@phalt phalt commented Feb 16, 2015

Doing a bit of testing with authentication and I noticed there was no mention of where to import the force_authenticate method anywhere, so I've added it to the first example where force_authenticate is introduced.

Fixes PEP8 W503 errors

@tomchristie
Copy link
Member

Yah.

@tomchristie
Copy link
Member

Damnit, really need to pin pep8.

@tomchristie
Copy link
Member

Bit meh to these silent upgrades.

We'll have to resolve it before we can merge anything else. Either pin pep8 to a lower version that's not so crazy about exactly where binary operators should be positioned, or by re-positioning 'em.

Eg:

Sorry - nothing related to your PR of course, but does block it.

@phalt
Copy link
Contributor Author

phalt commented Feb 16, 2015

Wow that's weird, I added a single line in the docs?

@phalt
Copy link
Contributor Author

phalt commented Feb 16, 2015

@tomchristie raise this as an issue / separate PR?

@tomchristie
Copy link
Member

I added a single line in the docs?

Testing against a newer version of pep8 than the previous commit/PR.
We pin flake8, but not pep8, which it depends on.

raise this as an issue / separate PR?

@phalt Yeah.

@phalt phalt mentioned this pull request Feb 16, 2015
@phalt
Copy link
Contributor Author

phalt commented Feb 16, 2015

Tox is pinning pep8 to pep8==1.5.7, yet still throwing the error. Looks like tox has flake8 pinned at 2.3.0 and not 2.2.2 like in requirements.txt.

@phalt
Copy link
Contributor Author

phalt commented Feb 16, 2015

I'll just fix the pep8 errors :)

@tomchristie
Copy link
Member

Looks like tox has flake8 pinned at 2.3.0 and not 2.2.2 like in requirements.txt.

https://github.com/tomchristie/django-rest-framework/blob/master/tox.ini#L26 How can it not be running 2.2.2?

@jpadilla
Copy link
Member

Wondering if now that we have #2568 this can be cleaned up to only include the missing import

@phalt
Copy link
Contributor Author

phalt commented Feb 18, 2015

@jpadilla I'll rebase and push

@phalt
Copy link
Contributor Author

phalt commented Feb 18, 2015

@tomchristie @jpadilla tah dah

jpadilla added a commit that referenced this pull request Feb 18, 2015
Add import example for force_authenticate in testing
@jpadilla jpadilla merged commit 4f1506c into encode:master Feb 18, 2015
@jpadilla
Copy link
Member

@phalt thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants