Skip to content

use SAFE_METHODS and make tuple #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2015
Merged

use SAFE_METHODS and make tuple #2705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rest_framework/permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from django.http import Http404
from rest_framework.compat import get_model_name

SAFE_METHODS = ['GET', 'HEAD', 'OPTIONS']
SAFE_METHODS = ('GET', 'HEAD', 'OPTIONS')


class BasePermission(object):
Expand Down Expand Up @@ -185,7 +185,7 @@ def has_object_permission(self, request, view, obj):
# they have read permissions to see 403, or not, and simply see
# a 404 response.

if request.method in ('GET', 'OPTIONS', 'HEAD'):
if request.method in SAFE_METHODS:
# Read permissions already checked and failed, no need
# to make another lookup.
raise Http404
Expand Down