Use serializer_class for browsable API display, even on plain APIView.
#2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you prefer to have a single commit |
No, fine as it is. |
|
Nice! |
|
Worth adding screenshots of before and after to the thread for these sort of pull requests, but looks great! :) |
tomchristie
changed the title
serializer_class for browsable API display, even on plain APIView.
|
Yeah I can do that |
|
Before: http://imgur.com/hc5hvru |
tomchristie
added a commit
that referenced
this pull request
Mar 23, 2015
Use `serializer_class` for browsable API display, even on plain APIView.
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complicates a little bit the logic in BrowsableAPIRenderer.get_rendered_html_form, but it allows to use view.serializer_class when get_serializer is not there.
I tested it locally and it seems to be working.