Should use "ordering" in model Meta, not order_by in Serializer Relations example [documentation] #2782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-brown
added a commit
that referenced
this pull request
Apr 1, 2015
Should use "ordering" in model Meta, not order_by in Serializer Relations example [documentation]
|
I have a feeling we referenced Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a really minor documentation fix - in the example models for Serializer Relations, the Tracks model should be using
ordering.order_byis an invalid Meta attribute and will result in the followingTypeError: 'class Meta' got invalid attribute(s): order_byThis felt a bit silly to PR, but I did actually get briefly tripped up by it in an end of day moment... so yea ;)