Move ul.breadcrumb margin to bootstrap-tweaks.css #2809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing other bootstrap themes from sites like bootswatch, the margin in default.css persists and adds a 70px margin below the header. This change will remove that margin when users choose to use a different bootstrap theme.
aparsons
changed the title
| ul.breadcrumb { | ||
| margin: 70px 0 0 0; | ||
| } | ||
|
|
||
| .breadcrumb li.active a { |
There was a problem hiding this comment.
Shouldn't this also be moved? It's associated with the other style.
There was a problem hiding this comment.
I'm not sure what you mean. I'm guessing your pointing out that default.css and bootstrap-tweaks.css share a similar purpose and could be merged into a single file.
There was a problem hiding this comment.
I was referring to the .breadcrumb li.active a block, which is directly associated with the ul.breadcrumb block that was moved.
I should have made that more clear as GitHub doesn't really point out where comments are attached to.
|
Looks like this is just waiting for update based on @kevin-brown's comment. |
Moved to color associated with the breadcrumb to the tweaks style sheet.
|
I moved the breadcrumb color over to the tweaks file as well. |
|
LGTM |
jpadilla
added a commit
that referenced
this pull request
Apr 26, 2015
Move ul.breadcrumb margin to bootstrap-tweaks.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing other bootstrap themes from sites like bootswatch, the
margin in default.css persists and adds a 70px margin below the header.
This change will remove that margin when users choose to use a different
bootstrap theme.