Include correct limits in LimitOffsetPagination link urls #3015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
LimitOffsetPagination
, if the limit from the query param is invalid or greater than themax_limit
, then the previous and next links should contain the actual limit being used instead of the originally requested limit.Examples:
default_limit
set, a request tohttp://testserver/?limit=hello
max_limit
set to 10, a request tohttp://testserver/?limit=100
should provide a next link with urlhttp://testserver/?limit=10&offset=10
instead ofhttp://testserver/?limit=100&offset=10