Add support for QueryDict data in serializers.ListField #3155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing case:
When user uploads multiple images (for example, <input type="file" name="image_files" multiple="">) and I try to serialize it with:
Serializer fails to evaluate "list of files".
Problem:
https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/fields.py#L1273
ListField class doesn't handle QueryDict-typed data properly.
Solution:
I haven't looked up for all codes related to this issue, so my PR is just a naive hotfix. I think there should be more consistent method to handle both QueryDict & MultiDict data types.