Skip to content

unnecessary strip() breaks markdown formatting #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nastasi-oq
Copy link
Contributor

  1. Is unnecessary
  2. Is breaking markdown formatting.

@nastasi-oq
Copy link
Contributor Author

For the test I need some coordinate, where I can copy from something similar ?

@carltongibson
Copy link
Collaborator

carltongibson commented Aug 31, 2017

@nastasi-oq It'll need to go in tests/test_schemas.py

  • In the test case, define an APIView with a markdown docstring. (Code block, nested list, ..., etc)
  • Call SchemaGenerator.get_description with the view instance, etc.
  • Check the return matched the expectation.

@nastasi-oq
Copy link
Contributor Author

nastasi-oq commented Aug 31, 2017

@carltongibson for me, now, is complete.

@nastasi-oq
Copy link
Contributor Author

@carltongibson so ?

@carltongibson
Copy link
Collaborator

@nastasi-oq Patience my friend 😀 Yes, we'll have this. (Thank you for your effort)

I'm just waiting for a final review from @tomchristie on #5354. At which point I'll merge that and then cherry-pick this into a new PR based on that. (There's nothing hard but everything has moved.)

Once that's in I'll also review #5374.

@nastasi-oq
Copy link
Contributor Author

nastasi-oq commented Sep 6, 2017

@carltongibson: I want just to know if it was ok also for you or need some code changes.
I'm not impatient, just to know if my work about this PR is finished 😀 .

@carltongibson
Copy link
Collaborator

This is updated in #5421. @nastasi-oq Thanks for the input. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants