Skip to content

Fix HiddenField stripping in BrowsableAPIRenderer #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Oct 13, 2017

This potentially fixes #5498 and related comments in #5929. Ideally, this would be tested, but I'm not familiar with the rendering/parsing tests.

@rpkilby
Copy link
Member Author

rpkilby commented Oct 13, 2017

Hi @oaaoaa, @jklaiho, and @seav, if you could install this branch and verify that this fixes the issue, that would be very helpful.

@rpkilby rpkilby added this to the 3.7.1 Release milestone Oct 13, 2017
@seav
Copy link

seav commented Oct 14, 2017

I can confirm that this resolves the KeyError issue. Thank you!

@jklaiho
Copy link

jklaiho commented Oct 16, 2017

Tested it as well, and the KeyError is no more. Looks good!

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. User feedback looks good. Lets have this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key error while building raw_data_form for a PUT request on ModelSerializer with extra field added in to_representation
4 participants