Localize DateTime field representations #5677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…representations if the value is truthy.
|
Hi @saturdayplace. Can you explain how this is different from the behaviour added in #5435? (What are you trying to achieve here exactly?) We need test cases and docs covering added behaviour. Also the test suite ended up very broken from this change I'm going to close this for now, as it looks to me as if #5435 already adds this, but I'm happy to re-open if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies fields.DateTimeField.to_representation() to check a new api_settings value, and localize the DateTime if the value is truthy.
I was surprised that DRF didn't do this already when the timezone for a request has been activated. Googling around brought me to people who are subclassing the DateTime field and adding this functionality, so I thought built-in localization of datetimes might be useful.