-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Pass python_requires argument to setuptools #5739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thought on this is "Yep, 👍, why not?"
Then I think:
- I need to check the syntax, but is an opt-in list not shorter, especially as we go on?
- Blue-skies: can we combine this somehow with maintaining the list of trove classifiers below.
I have a pet peeve with forgetting to update the supported versions in ≈3 or 4 different places; it would be nice to do something about that. (As I say "Blue-skies")
Writing some code here seems like it would be overly complicated. Maybe we can just add it to the release process checklist? eg,
|
Well, would it? (Maybe, yes.) I use I think updating the Release Process checklist with this would be a good addition pending any super code solution. |
Helps pip decide what version of the library to install. https://packaging.python.org/tutorials/distributing-packages/#python-requires > If your project only runs on certain Python versions, setting the > python_requires argument to the appropriate PEP 440 version specifier > string will prevent pip from installing the project on other Python > versions. https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords > python_requires > > A string corresponding to a version specifier (as defined in PEP 440) > for the Python version, used to specify the Requires-Python defined in > PEP 345.
I made the suggested docs edits. Please let me know if I interpreted the intentions correctly, that the change is in the right place, and is acceptable wording. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. That's great. Lets have it! 👍
Helps pip decide what version of the library to install. https://packaging.python.org/tutorials/distributing-packages/#python-requires > If your project only runs on certain Python versions, setting the > python_requires argument to the appropriate PEP 440 version specifier > string will prevent pip from installing the project on other Python > versions. https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords > python_requires > > A string corresponding to a version specifier (as defined in PEP 440) > for the Python version, used to specify the Requires-Python defined in > PEP 345.
Helps pip decide what version of the library to install.
https://packaging.python.org/tutorials/distributing-packages/#python-requires
https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords