Skip to content

Fixed active timezone handling for non ISO8601 datetimes. #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2018
Merged

Fixed active timezone handling for non ISO8601 datetimes. #5833

merged 2 commits into from
Feb 16, 2018

Conversation

carltongibson
Copy link
Collaborator

Updates and closes #5821.

  • Adds (previously failing) test for non-ISO8601 formatted datetimes, when overriding active timezone. (Thanks @hakib.)
  • Applies enforce_timezone in all cases, not just ISO 8601 datetimes.

@carltongibson carltongibson mentioned this pull request Feb 16, 2018
Closed
@carltongibson carltongibson added this to the 3.8 Release milestone Feb 16, 2018
@carltongibson carltongibson merged commit da535d3 into encode:master Feb 16, 2018
@carltongibson carltongibson deleted the pr/5821 branch February 16, 2018 15:47
@carltongibson carltongibson mentioned this pull request Feb 21, 2018
Closed
6 tasks
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@carltongibson
Fixed active timezone handling for non ISO8601 datetimes. (encode#5833)
8ed6901 
* Add failing test for to_representation with explicit default timezone

See discussion here:
    encode#5435 (comment)

* Always run enforce_timezone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@carltongibson @hakib