update testing.md - fixes related to RequestsClient #5959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import for RequestsClient is missing in the docs
Note that the requests client requires you to pass fully qualified URLs.
cgl
changed the title
tomchristie
reviewed
Apr 26, 2018
| assert response.status_code == 200 | ||
| csrftoken = response.cookies['csrftoken'] | ||
|
|
||
| # Interact with the API. | ||
| response = client.post('/organisations/', json={ | ||
| response = client.post('http://testserver/organisations/', json={ |
There was a problem hiding this comment.
We don't need to fully qualify the request. Let's leave these lines as they are.
There was a problem hiding this comment.
Yes with APIClient we don't need to fully qualify the request. But with RequestClient we need to. See the documentation for RequestClient:
http://www.django-rest-framework.org/api-guide/testing/#requestsclient
Note that the requests client requires you to pass fully qualified URLs.
tomchristie
requested changes
Apr 26, 2018
| @@ -201,6 +201,7 @@ live environment. (See "Live tests" below.) | |||
| This exposes exactly the same interface as if you were using a requests session | |||
| directly. | |||
|
|
|||
| from rest_framework.test import RequestsClient | |||
There was a problem hiding this comment.
Fair enough, yup, tho let's have a newline after this.
let's have a newline after RequestsClient import
tomchristie
approved these changes
Apr 26, 2018
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Include import for RequestsClient in the docs. * Use fully qualified URLs for `RequestsClient` in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import for RequestsClient is missing in the docs
Note: Before submitting this pull request, please review our contributing guidelines.
Description
Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use
refs #...in the description of the pull request.