Skip to content

tests: fix skipping with TestPosgresFieldsMapping #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 3, 2018

pytest.mark.skipUnless does not exist, it was confused with
unittest.skipUnless probably.

`pytest.mark.skipUnless` does not exist, it was confused with
`unittest.skipUnless` probably.
blueyed added a commit to blueyed/django-rest-framework that referenced this pull request May 3, 2018
This causes errors with invalid markers:

> AttributeError: 'skipUnless' not a registered marker

Fixes in encode#5965.
blueyed added a commit to blueyed/django-rest-framework that referenced this pull request May 3, 2018
This causes errors with invalid markers:

> AttributeError: 'skipUnless' not a registered marker

Fixed in encode#5965.
@blueyed blueyed mentioned this pull request May 3, 2018
@tomchristie
Copy link
Member

Nice catch. Thanks! 😄

@tomchristie tomchristie merged commit e79610a into encode:master May 3, 2018
@blueyed blueyed deleted the fix-skip branch May 3, 2018 13:07
tomchristie pushed a commit that referenced this pull request May 3, 2018
This causes errors with invalid markers:

> AttributeError: 'skipUnless' not a registered marker

Fixed in #5965.
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
`pytest.mark.skipUnless` does not exist, it was confused with
`unittest.skipUnless` probably.
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
This causes errors with invalid markers:

> AttributeError: 'skipUnless' not a registered marker

Fixed in encode#5965.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants