remove references to DOAC in docs #5977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-brown
approved these changes
May 8, 2018
rpkilby
approved these changes
May 8, 2018
|
Just as an aside, but I feel like we need to review the general state of 3rd-party packages. I would bet about $3.50 that there are several packages in a similar state to DOAC. |
rpkilby
suggested changes
May 8, 2018
| @@ -285,7 +285,6 @@ To submit new content, [open an issue][drf-create-issue] or [create a pull reque | |||
| [discussion-group]: https://groups.google.com/forum/#!forum/django-rest-framework | |||
| [djangorestframework-digestauth]: https://github.com/juanriaza/django-rest-framework-digestauth | |||
| [django-oauth-toolkit]: https://github.com/evonove/django-oauth-toolkit | |||
| [doac]: https://github.com/Rediker-Software/doac | |||
There was a problem hiding this comment.
The corresponding doac ref on line no 186 should be removed.
There was a problem hiding this comment.
Thanks, missed that! I was grepping for the wrong thing.
project has been archived on github and hasn't had any activity since 2014, and I'm not aware of an active fork.
|
Gotcha. Generally I'd be okay with us linking to unmaintained packages sometimes, as they might still be useful starting point. However in this case, the "archived" status, plus the explicit "Use Django OAuth Toolkit instead" is enough for us to remove the link entirely. Thanks! |
|
@rpkilby Good catch - thanks for the review! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Project has been archived on github and recommends alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project has been archived on github and hasn't had any activity since 2014, and I'm not aware of an active fork.