If choices is set on a models.TextField default to a select box rather than a text area #6182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause it will be converted to a ChoiceField and it is more appropriate to let this default to a select box
Codecov Report
@@ Coverage Diff @@
## master #6182 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 128 128
Lines 17630 17630
Branches 1458 1458
=======================================
Hits 16957 16957
Misses 465 465
Partials 208 208
Continue to review full report at Codecov.
|
rpkilby
suggested changes
Sep 12, 2018
There was a problem hiding this comment.
Hi @cpmbailey. If you could add a test, that would be appreciated.
|
Also cc @tomchristie @carltongibson - is this a change we would want to make? |
|
Superseded by #6892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not set the base_template style to textarea.html if choices is set; when it is converted to a ChoiceField it will use the default select.html instead.
refs #6181