Remove unnecessary use compat shim of six.binary_type #6189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6189 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 128 128
Lines 17645 17645
Branches 1460 1460
=======================================
Hits 16972 16972
Misses 465 465
Partials 208 208 |
The type bytes is available on all supported Pythons. On Python 2.7, it is an alias for str, same as six.binary_type. Makes the code more forward compatible with Python 3.
auvipy
approved these changes
Sep 17, 2018
carltongibson
approved these changes
Sep 17, 2018
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
The type bytes is available on all supported Pythons. On Python 2.7, it is an alias for str, same as six.binary_type. Makes the code more forward compatible with Python 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
bytesis available on all supported Pythons. On Python 2.7, it is an alias forstr, same assix.binary_type. Makes the code more forward compatible with Python 3.