Fix nullable source='*' fields
#6659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
force-pushed
the
nullable-complex-fields
branch
from
75eb2ff to
5b809a9
Compare
auvipy
reviewed
May 16, 2019
| # Nullable `source='*'` fields should not be skipped when its named | ||
| # field is given a null value. This is because `source='*'` means | ||
| # the field is passed the entire object, which is not null. | ||
| elif self.source == '*': |
There was a problem hiding this comment.
the fix seems to be very simple on!! good job
There was a problem hiding this comment.
Wasn't the intention to return empty dict from validate_empty_values in this case? Otherwise I see failure in to_internal_value with error 'Invalid data. Expected a dictionary, but got NoneType.'?
|
@rpkilby I guess I'm happy with this when you are. |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3451, #5635, and #6609.
Description
When a field like
CustomField(source='*', allow_null=True)is attempting to validate a null value, theField.validate_empty_values()method returns(True, None). This indicates that further validation should be skipped. However,set_valuebreaks, because the emptysource_attrsindicates that a dictionary should be provided, but the value returned fromvalidate_empty_valuesisNone.This an unusual edge case, but I'd argue it's valid. Although the given value may be null,
source='*'indicates that the field is validating the whole object, not just the given value. If we decide not validating is the correct behavior, thenvalidate_empty_valuesshould at least return an empty dict.Other considerations
I'm not entirely sure what the behavior should be when
CustomField(required=False)orSerializer(partial=True).