Skip to content

OpenAPI Schema Generation Fixes. #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2019
Merged

OpenAPI Schema Generation Fixes. #6827

merged 6 commits into from
Jul 24, 2019

Conversation

carltongibson
Copy link
Collaborator

Specifically: Closes #6675. Closes #6823.

  • Corrected one test, which was ultimately a logic error on my part, for common prefixes.
  • Adds another to check the url parameter functions as a mount point.
  • Fixes the above.
  • A couple of tidy-ups.

@tomchristie
Copy link
Member

Happy with this whenever you are.
Reckon we could probably roll a minor release either end of this week or start of next.

@carltongibson
Copy link
Collaborator Author

OK, ta. I'll pull it in later.

...roll a minor release ...

Sure, EOW I'd say. (#6819)

@carltongibson carltongibson merged commit 659375f into encode:master Jul 24, 2019
@carltongibson carltongibson deleted the openapi-schema-fixes branch July 24, 2019 09:13
@abellotti abellotti mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
Bug Schema Generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_schema_view() does not respect url= keyword argument OpenAPI schema generation missing path component when all paths under a common prefix
2 participants
@carltongibson @tomchristie