Fixed incorrect OpenAPI response schema generation for a DELETE method in generic views #6860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerated incorrect OpenAPI response body schema
|
I was wondering: what if a user overrides the |
6 tasks
|
Let’s not try to guess. We’ll cross that bridge when it comes up. (In the first place they can just subclass AutoSchema here.) |
|
Pushed an update! |
carltongibson
approved these changes
Aug 9, 2019
|
Nice! I have a couple of other issues, all related to OpenAPI generation. Would you be able to have a look? Also if I'm willing to work on these, should I attach detailed examples too? I tested and I know that those are bugs/issues. |
|
Yes, super. Create tickets, or straight to PR is you’ve got a fix already. Thanks! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
…d in generic views (encode#6860)
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
…d in generic views (encode#6860)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6856