Remove a few no longer needed compat checks and references #7092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UUIDField and DurationField are both supported in all supported Django versions. IPAddressField was removed in Django 1.9, which is no longer supported.
This way it's easier to see all of the mappings in one place.
The last release of DRF 2.x was 5 years ago, it seems fine to remove these references now.
tomchristie
approved these changes
Dec 16, 2019
rpkilby
approved these changes
Dec 16, 2019
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* serializers: removes no longer needed compat checks UUIDField and DurationField are both supported in all supported Django versions. IPAddressField was removed in Django 1.9, which is no longer supported. * serializers: move related code closer together This way it's easier to see all of the mappings in one place. * serializers,docs: remove some DRF 2.x references The last release of DRF 2.x was 5 years ago, it seems fine to remove these references now.
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
* serializers: removes no longer needed compat checks UUIDField and DurationField are both supported in all supported Django versions. IPAddressField was removed in Django 1.9, which is no longer supported. * serializers: move related code closer together This way it's easier to see all of the mappings in one place. * serializers,docs: remove some DRF 2.x references The last release of DRF 2.x was 5 years ago, it seems fine to remove these references now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few trivial things I noticed while browsing serializers.py. Please see the commits.