Skip to content

Fix docs 404 #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2020
Merged

Fix docs 404 #7197

merged 6 commits into from
Feb 20, 2020

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Feb 19, 2020

This fixes #7180 by linking to a valid API guide doc, but it also generally fixes our 404 styling. See individual commits for details.

The issue with the template is that the base_url for the 404 pages was /, so the templated URLs were like //foo.css instead of /foo.css. We could just remove the extra slash, but it's more correct to use the url template filter.

Update 404 page now looks like:
Screen Shot 2020-02-19 at 6 00 11 PM

@tomchristie tomchristie merged commit 92a4a5d into encode:master Feb 20, 2020
@tomchristie
Copy link
Member

Thanks so much @rpkilby!

@rpkilby rpkilby deleted the fix-docs404 branch February 20, 2020 17:35
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Use 'site_url' instead of hardcoding DRF homepage

* Use 'url' template filter instead of 'base_url'

This fixes static file loading for the 404 page.

* Only insert funding <hr> if toc is present

* Link quickstart to valid API guide page

* Fix 404 search modal link

* Use 'base_url' instead of 'site_url' on 404 page
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
* Use 'site_url' instead of hardcoding DRF homepage

* Use 'url' template filter instead of 'base_url'

This fixes static file loading for the 404 page.

* Only insert funding <hr> if toc is present

* Link quickstart to valid API guide page

* Fix 404 search modal link

* Use 'base_url' instead of 'site_url' on 404 page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"api guide" link broken in "Quickstart" documentation with broken 404 page
2 participants